Re: [PATCH 4/4] media: nvidia: tegra-vde: Fix iommu_map_sgtable() return value check

[Dmitry Osipenko]

21.04.2026 07:02, Mikko Perttunen пишет:
> Commit "iommu: return full error code from iommu_map_sg[_atomic]()"
> changed iommu_map_sgtable() to return an ssize_t and negative values
> in error cases, rather than a size_t and a zero.
> 
> Update tegra_vde_iommu_map() to correctly check for errors from
> iommu_map_sgtable.
> 
> Fixes: ad8f36e4b6b1 ("iommu: return full error code from iommu_map_sg[_atomic]()")
> Signed-off-by: Mikko Perttunen <mperttunen@xxxxxxxxxx>
> ---
>  drivers/media/platform/nvidia/tegra-vde/iommu.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/platform/nvidia/tegra-vde/iommu.c b/drivers/media/platform/nvidia/tegra-vde/iommu.c
> index b1d9d841d944..824d2aa80a43 100644
> --- a/drivers/media/platform/nvidia/tegra-vde/iommu.c
> +++ b/drivers/media/platform/nvidia/tegra-vde/iommu.c
> @@ -25,6 +25,7 @@ int tegra_vde_iommu_map(struct tegra_vde *vde,
>  	unsigned long shift;
>  	unsigned long end;
>  	dma_addr_t addr;
> +	ssize_t map_err;
>  
>  	end = vde->domain->geometry.aperture_end;
>  	size = iova_align(&vde->iova, size);
> @@ -36,11 +37,11 @@ int tegra_vde_iommu_map(struct tegra_vde *vde,
>  
>  	addr = iova_dma_addr(&vde->iova, iova);
>  
> -	size = iommu_map_sgtable(vde->domain, addr, sgt,
> -				 IOMMU_READ | IOMMU_WRITE);
> -	if (!size) {
> +	map_err = iommu_map_sgtable(vde->domain, addr, sgt,
> +				    IOMMU_READ | IOMMU_WRITE);
> +	if (map_err < 0) {
>  		__free_iova(&vde->iova, iova);
> -		return -ENXIO;
> +		return map_err;
>  	}
>  
>  	*iovap = iova;
> 

Acked-by: Dmitry Osipenko <digetx@xxxxxxxxx>