Re: [PATCH v3 2/2] PCI: cadence: Add debugfs property to provide LTSSM status of the PCIe link

From: Hans Zhang

Date: Wed May 06 2026 - 12:23:11 EST




On 5/7/26 00:06, Manivannan Sadhasivam wrote:
On Wed, May 06, 2026 at 11:52:06PM +0800, Hans Zhang wrote:

[...]

+static int ltssm_status_open(struct inode *inode, struct file *file)
+{
+ return single_open(file, ltssm_status_show, inode->i_private);
+}
+
+static const struct file_operations cdns_pcie_ltssm_status_ops = {
+ .open = ltssm_status_open,
+ .read = seq_read,
+};

Sashiko pointed out that you could use DEFINE_SHOW_ATTRIBUTE() to simplify the
code here.

I haven't received any notification from Sashiko. Next time, I'll go
directly to the website to check the relevant information. It seems that
Sashiko only sent out an email recently; I didn't receive any emails from
her before.


Yes, that's the recent behavior. Thanks to kwilczynski ;) You should get
notification for next iteration.

Wow, that's great!

Best regards,
Hans


- Mani