Re: [PATCH v5] iio: humidity: ens210: Fix missing I2C functionality checks

From: Jonathan Cameron

Date: Wed May 06 2026 - 12:30:14 EST


On Wed, 6 May 2026 12:17:42 +0200
Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:

> On Wed, 6 May 2026 at 12:13, Salah Triki <salah.triki@xxxxxxxxx> wrote:
> >
> > The ENS210 driver uses SMBus transactions (such as byte, word, and block
> > data reads/writes) during the probe and measurement phases. However, the
> > initial functionality check only validated a subset of these capabilities,
> > which could lead to loading failures on adapters requiring SMBus
> > emulation or native-only controllers.
> >
> > To ensure compatibility across a wide range of I2C adapters, modify the
> > functionality check to verify if the adapter supports the required native
> > operations or, failing that, supports the SMBus emulation layer.
> >
> > Fixes: c524fbca672e ("iio: humidity: Add support for ENS210")
> > Signed-off-by: Salah Triki <salah.triki@xxxxxxxxx>
> > ---
>
> Please slow down, you've sent two versions in the past 30 minutes.
>
> Alignment is fine, but refrain from sending patches that quickly.
>
The comments I just sent indeed applied to v2... So good advice
that you should slow down!

J