Re: [PATCH v6 00/12] Fixes and cleanups for the AD5686 IIO driver
From: Jonathan Cameron
Date: Wed May 06 2026 - 13:32:47 EST
On Tue, 5 May 2026 15:29:55 +0100
Rodrigo Alencar <455.rodrigo.alencar@xxxxxxxxx> wrote:
> On 26/05/05 03:59PM, Andy Shevchenko wrote:
> > On Tue, May 05, 2026 at 01:35:01PM +0100, Rodrigo Alencar via B4 Relay wrote:
> > > This is the first series of three on updating the AD5686 driver.
> > >
> > > A bigger patch series was sent before ("Extend device support for AD5686 driver"):
> > >
> > > https://lore.kernel.org/r/20260422-ad5313r-iio-support-v1-0-ed7dca001d1b@xxxxxxxxxx
> > >
> > > This one adds a number of cleanups and fixes, like:
> > > - Refactor include headers (IWYU);
> > > - Remove redundant register definition;
> > > - Drop enum chip id in favor of per-device chip_info structs;
> > > - Fix internal voltage reference control for single-channel devices;
> > > - Acquire lock when doing power down control;
> > > - Fix powerdown control for dual-channel devices;
> >
> > > ---
> > > Changes in v6:
> > > - Protect powerdown masks on read access too.
> > > - Minor changes to power down handling and constants.
> >
> > You were too fast, Jonathan applied some patches already.
>
> I understood He had applied the some of the fixes and was to wait on the fix
> for the lockless read access issue to proceed. Also, most of the series have
> been reviewed already. Indeed, I suppose I've been hurrying up things... will
> slow down!
>
If you do a new version (I didn't have any other comments to add
on the remaining patches) then please just drop the fixes I've applied
off the start and note that the series is dependent on the tag in the
fixes-togreg branch. No idea if sashiko will cope with that but humans will ;)