Re: [PATCH v2] PCI: brcmstb: Assign pcie->gen from of_pci_get_max_link_speed()

[Florian Fainelli]

On 5/6/26 10:08, Manivannan Sadhasivam wrote:
> On Wed, May 06, 2026 at 09:45:37AM -0700, Florian Fainelli wrote:
> > After commit 03f920936977 ("PCI: controller: Validate max-link-speed"),
> > pcie->gen stopped being assigned and as a result the established PCIe
> > link would stop supporting Gen3 speeds on 2712 since pcie->gen is used
> > to populate LnkCntl2 and LnkCap in brcm_pcie_set_gen().
> >
> > Whether the 'max-link-speed' property is not specified, or it exceeds
> > Gen3, resort to the HW defaults.
> >
> > Link: https://github.com/raspberrypi/linux/issues/7343
> > Reported-by: Dom Cobley <popcornmix@xxxxxxxxx>
> > Reported-by: Phil Elwell <phil@xxxxxxxxxxxxxxx>
> > Fixes: 03f920936977 ("PCI: controller: Validate max-link-speed")
> > Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
>
> Since this is a 7.1 material:
>
> Reviewed-by: Manivannan Sadhasivam <mani@xxxxxxxxxx>

Thanks!

> > Change-Id: Ic5431469dd7a6c8b391f84f27119dad876256880
>
> This Change-Id is irrelevant to upstream.

Should I resubmit or can it be stripped while applying?
--
Florian