Re: [PATCH v8 10/21] x86/virt/seamldr: Shut down the current TDX module
From: Dave Hansen
Date: Wed May 06 2026 - 16:49:37 EST
On 5/5/26 19:56, Chao Gao wrote:
> On Thu, Apr 30, 2026 at 11:52:50AM -0700, Dave Hansen wrote:
>> On 4/27/26 08:28, Chao Gao wrote:
>>> static int do_seamldr_install_module(void *seamldr_params)
>>> {
>>> enum module_update_state newstate, curstate = MODULE_UPDATE_START;
>>> + int cpu = smp_processor_id();
>>> + bool primary;
>>> int ret = 0;
>>>
>>> + primary = cpumask_first(cpu_online_mask) == cpu;
>> Isn't cpumask_first(cpu_online_mask)==0, always? I thought CPU 0 could
>> never be offlined.
> Not always. On x86, CPU 0 can be offlined at runtime if the kernel is booted
> with the cpu0_hotplug command-line option. See cpu_hotplug.rst.
See e59e74dc48a309cb848ffc3d76a0d61aa6803c05.
Yes, the docs are stale.