Re: [PATCH] pinctrl: qcom: Unconditionally mark gpio as wakeup enable

[Sneh Mankad]

On 05-May-26 3:58 PM, Linus Walleij wrote:

> On Thu, Apr 30, 2026 at 7:54 AM Sneh Mankad
> <sneh.mankad@xxxxxxxxxxxxxxxx> wrote:
>
> > The wakeup enable bit needs to be set irrespective of the SoC using PDC or
> > MPM as wakeup capable irqchip to allow the GPIO interrupts to be forwarded
> > to parent irqchip.
> >
> > This is set only for PDC irqchip using additional check skip_wake_irqs
> > making it impossible for MPM irqchip to detect the GPIO interrupt during
> > SoC low power mode since for MPM irqchip the skip_wake_irqs is always
> > false.
> >
> > Remove skip_wake_irqs condition when setting wakeup enable bit to allow
> > forwarding GPIO interrupts for SoCs using MPM irqchip too.
> >
> > Fixes: 76b446f5b86e ("pinctrl: qcom: handle intr_target_reg wakeup_present/enable bits")
> > Signed-off-by: Sneh Mankad <sneh.mankad@xxxxxxxxxxxxxxxx>
> Good work here, also super-dangerous so if some more Qualcomm
> engineers could pitch in on this patch it'd be great.
>
> Is this an urgent (-rc) or nonurgent (next) fix?
>
> Yours,
> Linus Walleij

Its fine if it gets picked in the next release.

Thanks

Sneh