Re: [PATCH] nvme: use str_enabled_disabled() for digest mismatch messages

From: Christoph Hellwig

Date: Thu May 07 2026 - 01:32:13 EST


On Mon, May 04, 2026 at 06:05:55PM +0530, Rohit Chavan wrote:
> pr_err("queue %d: data digest mismatch host: %s ctrl: %s\n",
> nvme_tcp_queue_id(queue),
> - queue->data_digest ? "enabled" : "disabled",
> - ctrl_ddgst ? "enabled" : "disabled");
> + str_enabled_disabled(queue->data_digest),
> + str_enabled_disabled(ctrl_ddgst));

I can't really see how this is considered an improvement.