Re: [PATCH v3 03/10] iio: accel: mma8452: cleanup codestyle warning

[Joshua Crofts]

On Wed, 6 May 2026 at 19:54, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> > This is still not aligned by 1 character, it should be aligned with the first
> > character after the opening parenthesis.
>
> Hi Joshua,
>
> Trap of reading patches in emails is that tabs and space combinations don't
> always look correct. Also your email client replaced them all with spaces
> to add more confusion ;)
>
> From origin patch
>
>  static int __mma8452_write_raw(struct iio_dev *indio_dev,
> -                            struct iio_chan_spec const *chan,
> -                            int val, int val2, long mask)
> +                              struct iio_chan_spec const *chan,
> +                              int val, int val2, long mask)
>  {
>
> With the leading chars removed removes one space from top line
> but nothing from the following ones as they have leading tabs.
>
> So you get:
>
> static int __mma8452_write_raw(struct iio_dev *indio_dev,
>                                struct iio_chan_spec const *chan,
>                                int val, int val2, long mask)
> {
>
> So this is fine.  I haven't checked the others but guess they are the same.
>
> I frequently end up testing this by hand when I think indents are off
> and often turns out I'm wrong!
>
> ...
>
> >
> > The rest is correct though.
> They all have leading tabs on all lines.

I guess nothing beats just applying the patch manually and checking in
an editor. Thanks for the clarification - gmail really does mangle formatting
horribly.

-- 
Kind regards

CJD