Re: [PATCH net-next 2/3] ppp: unify two channel structs

From: Qingfang Deng

Date: Thu May 07 2026 - 05:23:05 EST

On 2026/5/7 16:46, Sebastian Andrzej Siewior wrote:
On 2026-05-07 16:33:36 [+0800], Qingfang Deng wrote:
On 2026/5/7 15:40, Sebastian Andrzej Siewior wrote:
On 2026-05-07 13:53:30 [+0800], Qingfang Deng wrote:
This patch is IMHO a bit too big and should be split. Also this kind of
refactor looks very invasive and potentially regression prone. I think
it should include a signficant self-test coverage increase.
This is indeed too big. But how do I split it without breaking the build?
The current ppp tests would yell if you accidentally broke something?
By "breaking the build" I meant compile-time errors (due to API changes).
If this change would flip the logic somewhere and as such break ppp at
runtime.
Would the existing test suite be able to catch it?


The current self-test only covers PPP async and PPPoE, and that's why Paolo suggests more self-tests.