Re: [PATCH v3 2/2] drm: verisilicon: add support for cursor planes

[Dmitry Baryshkov]

On Thu, May 07, 2026 at 01:56:10AM +0800, Icenowy Zheng wrote:
> Verisilicon display controllers support hardware cursors per output
> port.
> 
> Add support for them as cursor planes.
> 
> Signed-off-by: Icenowy Zheng <zhengxingda@xxxxxxxxxxx>
> ---
> Changes in v3:
> - Moved the validity check for max_cursor_size to
>   vs_cursor_plane_init().
> - Removed NULL check for new_plane_state->fb because
>   drm_atomic_helper_check_plane_state() will set visibility to false in
>   such case.
> Changes in v2:
> - Use is_power_of_two instead of switch to validate cursor size.
> - Remove unneeded format check.
> - Skip the whole validity check if the plane is invisible (previously
>   it's only skipped when the plane is not bound to CRTC).
> - Explicitly set modifiers list (linear only).
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>


-- 
With best wishes
Dmitry