Re: [PATCH v10 0/7] Add AMD ISP4 driver

[sakari.ailus@xxxxxxxxxxxxxxx]

Hi Bin,

On Thu, May 07, 2026 at 02:44:32PM +0800, Bin Du wrote:
> Hi Sakari,
> 
> I'm not sure which Smatch version is used in Media CI. Here are some
> findings from my local tests for reference.
> 
> For v10, I could reproduce the false positive with an older Smatch snapshot
> built from upstream commit URL:https://repo.or.cz/smatch.git/commit/bc575c7a0c5c7a2d4fefd0e1d8b0dc9ccacdd1a6,
> which is a pre-1.74 snapshot.
> 
> I could not reproduce the same false positive with a newer Smatch snapshot
> based on upstream commit URL:https://repo.or.cz/smatch.git/commit/bcc58b9ccf06d28ab6be4f0992bc74f462aa12f8,
> which is a post-1.75 snapshot.
> 
> For v11, neither Smatch snapshot reports the warning.

That's nice. Smatch is updated weekly so we should get the new smatch in
soon and you could post a patch to remove the workaround. The code would be
nicer without that.

The patches themselves were merged earlier today to the media committers
tree.

-- 
Regards,

Sakari Ailus