Re: [PATCH ipsec-next v8 01/14] xfrm: remove redundant assignments

[Sabrina Dubroca]

2026-05-05, 06:31:28 +0200, Antony Antony wrote:
> These assignments are overwritten within the same function further down
> 
> commit e8961c50ee9cc ("xfrm: Refactor migration setup
> during the cloning process")
> x->props.family = m->new_family;
> 
> Which actually moved it in the
> commit e03c3bba351f9 ("xfrm: Fix xfrm migrate issues when address family changes")
> 
> And the initial
> commit 80c9abaabf428 ("[XFRM]: Extension for dynamic update of endpoint address(es)")
> 
> added x->props.saddr = orig->props.saddr; and
> memcpy(&xc->props.saddr, &m->new_saddr, sizeof(xc->props.saddr));
> 
> Signed-off-by: Antony Antony <antony.antony@xxxxxxxxxxx>
> 
> ---
> v1->v2: remove extra saddr copy, previous line
> ---
>  net/xfrm/xfrm_state.c | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Sabrina Dubroca <sd@xxxxxxxxxxxxxxx>

-- 
Sabrina