Re: [PATCH] net/sched: sch_dualpi2: annotate lockless accesses in dualpi2_dump_stats()
From: Eric Dumazet
Date: Thu May 07 2026 - 06:42:06 EST
On Thu, May 7, 2026 at 3:20 AM Vineet Agarwal
<agarwal.vineet2006@xxxxxxxxx> wrote:
>
> dualpi2_dump_stats() is called without holding qdisc lock.
>
> Several statistics fields are concurrently updated from enqueue and
> dequeue paths while being read locklessly from dualpi2_dump_stats().
>
> Annotate these accesses with READ_ONCE().
>
> Signed-off-by: Vineet Agarwal <agarwal.vineet2006@xxxxxxxxx>
> ---
Thanks for the patch. This was on my plate.
1) This is probably targeting net tree. You must select either net or net-next.
2) We need a Fixes: tag.
3) WRITE_ONCE() annotations are missing from your patch.
4) Please wait ~24 hours before sending a V2
More details in: Documentation/process/maintainer-netdev.rst
pw-bot: cr