Re: [PATCH] firmware: psci: Set pm_set_resume/suspend_via_firmware() for SYSTEM_SUSPEND

[Manivannan Sadhasivam]

On Thu, May 07, 2026 at 11:54:08AM +0100, Jon Hunter wrote:
> 
> On 06/05/2026 18:18, Manivannan Sadhasivam wrote:
> > On Tue, May 05, 2026 at 02:47:08PM +0100, Jon Hunter wrote:
> > > Hi Mani,
> > > 
> > > On 06/04/2026 15:29, Manivannan Sadhasivam wrote:
> > > 
> > > ...
> > > 
> > > > Sure. It makes logical sense to relate this API behavior with the state of CX.
> > > > I'll send v2 with the updated commit message.
> > > 
> > > Did you ever send a V2? I am not sure if I missed it and so wanted to check.
> > > 
> > 
> > No, I didn't. I had some offline discussions with Bjorn and concluded that it
> > might not be appropriate to set pm_set_resume/suspend_via_firmware() for all
> > firmware flavors that our Qcom SoCs support.
> > 
> > Then I found out a limitation with our Root Complex IPs in exiting L1ss if the
> > platform is suspended. So sent out a series to fix that and that allowed me to
> > get past the NVMe issue coincidentally.
> > 
> > But since this patch applies to other ARM64 SoCs, it logically makes sense to
> > apply it IMO. So, I'll leave it to PSCI maintainers to decide.
> 
> 
> I am not sure I follow the above. Sounds like you don't want to apply this
> because it may not work for all Qualcomm SoCs, but regardless of that you
> will leave to the PSCI maintainers to decide?
> 

No, I was saying that there is no need to respin this patch and the PSCI
maintainers can apply this patch as-is.

> Anyway, I have resumed the discussion on the original thread [0] because
> this has been broken now for the last two kernel releases.
> 

Sure. We were carrying out-of-tree patch to fix this issue ever since we started
supporting NVMe on Qcom SoCs ;)

- Mani

-- 
மணிவண்ணன் சதாசிவம்