Re: [PATCH v3 03/10] firmware: samsung: acpm: Drop redundant _ops suffix in acpm_ops members
From: Lee Jones
Date: Thu May 07 2026 - 08:01:58 EST
On Mon, 20 Apr 2026, Tudor Ambarus wrote:
> Rename the `dvfs_ops` and `pmic_ops` members of `struct acpm_ops` to
> `dvfs` and `pmic` respectively.
>
> Since these members are housed within the `acpm_ops` structure and
> utilize the `acpm_*_ops` types, the `_ops` suffix on the variable names
> creates unnecessary redundancy (e.g., `handle.ops.dvfs_ops`).
>
> This cleanup removes the stuttering, leading to cleaner consumer code.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
> ---
> drivers/clk/samsung/clk-acpm.c | 8 ++++----
> drivers/firmware/samsung/exynos-acpm.c | 4 ++--
> drivers/mfd/sec-acpm.c | 6 +++---
Acked-by: Lee Jones <lee@xxxxxxxxxx>
> include/linux/firmware/samsung/exynos-acpm-protocol.h | 4 ++--
> 4 files changed, 11 insertions(+), 11 deletions(-)
--
Lee Jones