RE: [PATCH v3 5/6] arm64: dts: renesas: rzg3l-smarc-som: Add pinctrl configuration for ETH0

[Biju Das]

Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 07 May 2026 13:01
> Subject: Re: [PATCH v3 5/6] arm64: dts: renesas: rzg3l-smarc-som: Add pinctrl configuration for ETH0
> 
> Hi Biju,
> 
> On Thu, 30 Apr 2026 at 14:53, Biju <biju.das.au@xxxxxxxxx> wrote:
> > From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >
> > Add pin control configuration for the ETH0 Ethernet interface on the
> > RZ/G3L SMARC SoM board and also enable hotplug support.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v3:
> >  * Split from patch#6
> >  * Added hotplug support.
> 
> Thanks for the update!
> 
> > --- a/arch/arm64/boot/dts/renesas/rzg3l-smarc-som.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzg3l-smarc-som.dtsi
> 
> > @@ -52,3 +55,32 @@ phy0: ethernet-phy@7 {
> >                 txd3-skew-psec = <0>;
> >         };
> >  };
> > +
> > +&pinctrl {
> > +       eth0_pins: eth0 {
> > +               txc {
> > +                       pinmux = <RZG3L_PORT_PINMUX(B, 1, 1)>;  /* ETH0_TXC_REF_CLK */
> > +                       power-source = <1800>;
> > +                       output-enable;
> > +                       drive-strength-microamp = <5200>;
> > +               };
> > +
> > +               ctrl {
> > +                       pinmux = <RZG3L_PORT_PINMUX(A, 1, 1)>, /* MDC */
> > +                                <RZG3L_PORT_PINMUX(A, 0, 1)>, /* MDIO */
> > +                                <RZG3L_PORT_PINMUX(C, 2, 15)>, /* PHY_INTR */
> > +                                <RZG3L_PORT_PINMUX(C, 1, 1)>, /* RXD3 */
> > +                                <RZG3L_PORT_PINMUX(C, 0, 1)>, /* RXD2 */
> > +                                <RZG3L_PORT_PINMUX(B, 7, 1)>, /* RXD1 */
> > +                                <RZG3L_PORT_PINMUX(B, 6, 1)>, /* RXD0
> > + */
> 
> I will sort in ascending order while applying.

OK.

> 
> > +                                <RZG3L_PORT_PINMUX(B, 0, 1)>, /* RXC */
> > +                                <RZG3L_PORT_PINMUX(A, 2, 1)>, /* RX_CTL */
> > +                                <RZG3L_PORT_PINMUX(B, 5, 1)>, /* TXD3 */
> > +                                <RZG3L_PORT_PINMUX(B, 4, 1)>, /* TXD2 */
> > +                                <RZG3L_PORT_PINMUX(B, 3, 1)>, /* TXD1 */
> > +                                <RZG3L_PORT_PINMUX(B, 2, 1)>, /* TXD0
> > + */
> 
> Likewise.

OK. Thanks for taking caring it.

Cheers,
Biju

> 
> > +                                <RZG3L_PORT_PINMUX(A, 3, 1)>; /* TX_CTL */
> > +                                power-source = <1800>;
> > +               };
> > +       };
> > +};
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in renesas-devel for v7.2.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But when I'm talking to
> journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds