RE: [PATCH v3 6/6] arm64: dts: renesas: rzg3l-smarc-som: Enable eth1 (GBETH1) interface

[Biju Das]

Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 07 May 2026 13:02
> Subject: Re: [PATCH v3 6/6] arm64: dts: renesas: rzg3l-smarc-som: Enable eth1 (GBETH1) interface
> 
> Hi Biju,
> 
> On Thu, 30 Apr 2026 at 14:53, Biju <biju.das.au@xxxxxxxxx> wrote:
> > From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >
> > Enable the Gigabit Ethernet Interface (GBETH1) populated on the RZ/G3L
> > SMARC EVK.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v2->v3:
> >  * Dropped ethernet-phy-ieee802.3-c22 from mdio1 device node.
> >  * Fixed typo txdv-skew-psec -> txen-skew-psec.
> >  * Added hotplug support.
> 
> Thanks for the update!
> 
> > --- a/arch/arm64/boot/dts/renesas/rzg3l-smarc-som.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzg3l-smarc-som.dtsi
> > @@ -83,4 +117,31 @@ ctrl {
> >                                  power-source = <1800>;
> >                 };
> >         };
> > +
> > +       eth1_pins: eth1 {
> > +               txc {
> > +                       pinmux = <RZG3L_PORT_PINMUX(E, 1, 1)>;  /* ETH1_TXC_REF_CLK */
> > +                       power-source = <1800>;
> > +                       output-enable;
> > +                       drive-strength-microamp = <5200>;
> > +               };
> > +
> > +               ctrl {
> > +                       pinmux = <RZG3L_PORT_PINMUX(D, 1, 1)>, /* MDC */
> > +                                <RZG3L_PORT_PINMUX(D, 0, 1)>, /* MDIO */
> > +                                <RZG3L_PORT_PINMUX(F, 2, 15)>, /* PHY_INTR */
> > +                                <RZG3L_PORT_PINMUX(F, 1, 1)>, /* RXD3 */
> > +                                <RZG3L_PORT_PINMUX(F, 0, 1)>, /* RXD2 */
> > +                                <RZG3L_PORT_PINMUX(E, 7, 1)>, /* RXD1 */
> > +                                <RZG3L_PORT_PINMUX(E, 6, 1)>, /* RXD0
> > + */
> 
> I will sort in ascending order while applying.

OK.

> 
> > +                                <RZG3L_PORT_PINMUX(E, 0, 1)>, /* RXC */
> > +                                <RZG3L_PORT_PINMUX(D, 2, 1)>, /* RX_CTL */
> > +                                <RZG3L_PORT_PINMUX(E, 5, 1)>, /* TXD3 */
> > +                                <RZG3L_PORT_PINMUX(E, 4, 1)>, /* TXD2 */
> > +                                <RZG3L_PORT_PINMUX(E, 3, 1)>, /* TXD1 */
> > +                                <RZG3L_PORT_PINMUX(E, 2, 1)>, /* TXD0
> > + */
> 
> Likewise.

Thanks, for taking care of it.

Cheers,
Biju

> 
> > +                                <RZG3L_PORT_PINMUX(D, 3, 1)>; /* TX_CTL */
> > +                                power-source = <1800>;
> > +               };
> > +       };
> >  };
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in renesas-devel for v7.2.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But when I'm talking to
> journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds