Re: [PATCH v2] staging: rtl8723bs: simplify NULL pointer checks

[Nikolay Kulikov]

On Thu, May 07, 2026 at 12:32:01AM +0530, Mohammed Sohail wrote:
> Replace ptr == NULL with !ptr in rtw_recv.h and ioctl_cfg80211.c.
> 
> Improves readability and follows kernel coding style.
> No functional changes.
> 
> Signed-off-by: Mohammed Sohail <mohd.sohail.biz@xxxxxxxxx>
> ---
> v2:
> - Use real name in Signed-off-by as requested by reviewer
> ---
>  drivers/staging/rtl8723bs/include/rtw_recv.h      | 8 ++++----
>  drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/rtw_recv.h b/drivers/staging/rtl8723bs/include/rtw_recv.h
> index 8e45871f07f0..9c32d480a20a 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_recv.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_recv.h
> @@ -349,7 +349,7 @@ s32  rtw_recv_entry(union recv_frame *precv_frame);
>  static inline u8 *get_rxmem(union recv_frame *precvframe)
>  {
>  	/* always return rx_head... */
> -	if (precvframe == NULL)
> +	if (!precvframe)
>  		return NULL;
>  
>  	return precvframe->u.hdr.rx_head;
> @@ -362,7 +362,7 @@ static inline u8 *recvframe_pull(union recv_frame *precvframe, signed int sz)
>  	/* used for extract sz bytes from rx_data, update rx_data and return the updated rx_data to the caller */
>  
>  
> -	if (precvframe == NULL)
> +	if (!precvframe)
>  		return NULL;
>  
>  
> @@ -387,7 +387,7 @@ static inline u8 *recvframe_put(union recv_frame *precvframe, signed int sz)
>  	/* after putting, rx_tail must be still larger than rx_end. */
>  	unsigned char *prev_rx_tail;
>  
> -	if (precvframe == NULL)
> +	if (!precvframe)
>  		return NULL;
>  
>  	prev_rx_tail = precvframe->u.hdr.rx_tail;
> @@ -414,7 +414,7 @@ static inline u8 *recvframe_pull_tail(union recv_frame *precvframe, signed int s
>  	/* used for extract sz bytes from rx_end, update rx_end and return the updated rx_end to the caller */
>  	/* after pulling, rx_end must be still larger than rx_data. */
>  
> -	if (precvframe == NULL)
> +	if (!precvframe)
>  		return NULL;
>  
>  	precvframe->u.hdr.rx_tail -= sz;
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> index fd3bae31b0ed..8ae3adecafd9 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> @@ -2429,7 +2429,7 @@ static int	cfg80211_rtw_dump_station(struct wiphy *wiphy,
>  	spin_lock_bh(&pstapriv->asoc_list_lock);
>  	psta = rtw_sta_info_get_by_idx(idx, pstapriv);
>  	spin_unlock_bh(&pstapriv->asoc_list_lock);
> -	if (psta == NULL) {
> +	if (!psta) {
>  		ret = -ENOENT;
>  		goto exit;
>  	}

This does not apply to staging-next.


Thanks,
Nikolay