Re: [PATCH net-next v3 1/4] net: eth: fbnic: Fix addr validation in pcs write

[Mike Marciniszyn]

On Thu, May 07, 2026 at 09:20:45AM -0400, Mike Marciniszyn wrote:
> On Thu, May 07, 2026 at 09:20:53AM +0200, Paolo Abeni wrote:
> > On 5/7/26 3:58 AM, Jakub Kicinski wrote:
> > > On Mon,  4 May 2026 09:58:12 -0400 mike.marciniszyn@xxxxxxxxx wrote:
> > >> From: "Mike Marciniszyn (Meta)" <mike.marciniszyn@xxxxxxxxx>
> > >>
> > >> The DW IP has two distinct PCS address ranges cooresponding
> > >> to the C45 PCS registers.
> > >>
> > >> The shim translates the PCS addr/regno into specific CSR writes
> > >> into one of those two zero-relative.
> > >>
> > >> This patch fixes a one off in the test that could allow an invalid
> > >> CSR write if an addr == 2 was called.
> > >>
> > >> This patch contains a fix for addr validation in fbnic_mdio_write_pcs()
> > >> to only return actual CSR reads for addr 0 and 1.
> > >>
> > >> There are as of yet, no real impact for the bug as no PCS writes are
> > >> not yet present.
> > >
> > > Hi Paolo! Was there a reason / do you recall why this was not applied?
> > > (I dropped it from patchwork now. If the omission was accidental it has
> > > to be reposted)
> >
> > Darn, limited capacity here plus re-submission glitch: v3 had a slightly
> > different cover title (due to typo) WRT v2 so PW did not mark v2 as
> > superseded. I process patches via PW in sequence, when I reached v2 I
> > considered the sashiko comment not blocking and I apply it. I was unable
> > to reach v3 until now.
> >
> > TL;DR: @Mike: please re-submit 1/4 and double check there are not other
> > differences between v2 and v3 - otherwise more patches needed. Also
> > please ensure you keep the series title consistent among revision, or at
> > least manually remove old revisions from PW upon resubmission.
> >
> > Thanks,
> >
> > Paolo
> >
>
> I double checked v2 -> v3 for the other patches are ok.
>
> I'm just now resending 1/4 of the series.  I reworded the commit message
> to fix the AI review comment.
>
> Mike

The patch isn't showing up on either lore or patchwork.

I may need to bump the rev?

Mike