Re: [PATCH v4 10/29] drm/msm/adreno: use new helper to set macrotile_mode
From: Akhil P Oommen
Date: Thu May 07 2026 - 10:01:09 EST
On 5/7/2026 6:33 PM, Dmitry Baryshkov wrote:
> Use freshly defined helper instead of using the raw value from the
> database.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +-
> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> index 812bb95e8011..76c681614416 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> @@ -791,7 +791,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu)
> min_acc_len_64b << 23 | hbb_lo << 21);
>
> gpu_write(gpu, REG_A6XX_RBBM_NC_MODE_CNTL,
> - cfg->macrotile_mode);
> + qcom_ubwc_macrotile_mode(cfg));
> }
>
> static void a7xx_patch_pwrup_reglist(struct msm_gpu *gpu)
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> index 66f80f2d12f9..bf1572156b0b 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> @@ -433,7 +433,7 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_context *ctx,
> *value = adreno_gpu->ubwc_config->ubwc_swizzle;
> return 0;
> case MSM_PARAM_MACROTILE_MODE:
> - *value = adreno_gpu->ubwc_config->macrotile_mode;
> + *value = qcom_ubwc_macrotile_mode(adreno_gpu->ubwc_config);
> return 0;
> case MSM_PARAM_UCHE_TRAP_BASE:
> *value = adreno_gpu->uche_trap_base;
>
Reviewed-by: Akhil P Oommen <akhilpo@xxxxxxxxxxxxxxxx>
-Akhil.