Re: [PATCH 07/13] media: imx355: Remove link_freq_index from each mode as ununsed
From: Jacopo Mondi
Date: Thu May 07 2026 - 10:15:55 EST
Hi Dave
On Wed, May 06, 2026 at 07:23:45PM +0100, Dave Stevenson wrote:
> The link_freq_index value in imx355_mode is unused, so remove it.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
Reviewed-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/i2c/imx355.c | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
> index 422454e529a7..b0cddb614775 100644
> --- a/drivers/media/i2c/imx355.c
> +++ b/drivers/media/i2c/imx355.c
> @@ -82,7 +82,6 @@
>
> /* default link frequency and external clock */
> #define IMX355_LINK_FREQ_DEFAULT 360000000LL
> -#define IMX355_LINK_FREQ_INDEX 0
>
> /* number of data lanes */
> #define IMX355_DATA_LANES 4
> @@ -111,9 +110,6 @@ struct imx355_mode {
> /* H-timing */
> u32 llp;
>
> - /* index of link frequency */
> - u32 link_freq_index;
> -
> /* Default register values */
> struct imx355_reg_list reg_list;
>
> @@ -367,7 +363,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 2615,
> .fll_min = 2615,
> .llp = 3672,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_3280x2464_regs),
> .regs = mode_3280x2464_regs,
> @@ -384,7 +379,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 2615,
> .fll_min = 2615,
> .llp = 3672,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_3268x2448_regs),
> .regs = mode_3268x2448_regs,
> @@ -401,7 +395,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 2615,
> .fll_min = 2615,
> .llp = 3672,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_3264x2448_regs),
> .regs = mode_3264x2448_regs,
> @@ -418,7 +411,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 3672,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1940x1096_regs),
> .regs = mode_1940x1096_regs,
> @@ -435,7 +427,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 3672,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1936x1096_regs),
> .regs = mode_1936x1096_regs,
> @@ -452,7 +443,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 3672,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1924x1080_regs),
> .regs = mode_1924x1080_regs,
> @@ -469,7 +459,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 3672,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1920x1080_regs),
> .regs = mode_1920x1080_regs,
> @@ -486,7 +475,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 1836,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1640x1232_regs),
> .regs = mode_1640x1232_regs,
> @@ -503,7 +491,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 1836,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1640x922_regs),
> .regs = mode_1640x922_regs,
> @@ -520,7 +507,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 1836,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1300x736_regs),
> .regs = mode_1300x736_regs,
> @@ -537,7 +523,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 1836,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1296x736_regs),
> .regs = mode_1296x736_regs,
> @@ -554,7 +539,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 1836,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1284x720_regs),
> .regs = mode_1284x720_regs,
> @@ -571,7 +555,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 1306,
> .fll_min = 1306,
> .llp = 1836,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_1280x720_regs),
> .regs = mode_1280x720_regs,
> @@ -588,7 +571,6 @@ static const struct imx355_mode supported_modes[] = {
> .fll_def = 652,
> .fll_min = 652,
> .llp = 3672,
> - .link_freq_index = IMX355_LINK_FREQ_INDEX,
> .reg_list = {
> .num_of_regs = ARRAY_SIZE(mode_820x616_regs),
> .regs = mode_820x616_regs,
>
> --
> 2.34.1
>
>