Re: [PATCH v7 1/7] fs/resctrl: Tidy up the error path in resctrl_mkdir_event_configs()

[Borislav Petkov]

On Wed, May 06, 2026 at 10:05:36AM -0500, Moger, Babu wrote:
> Minor nit. You can directly return like below.
> 
> return PTR_ERR(kn_subdir2);
> 
> Optional, only if there is another version.

Fixed:

commit 7625632fed431ddd655e839c302165536553f767
Author: Ben Horgan <ben.horgan@xxxxxxx>
Date:   Wed May 6 09:28:49 2026 +0100

    fs/resctrl: Tidy up the error path in resctrl_mkdir_event_configs()
    
    The error path in resctrl_mkdir_event_configs() is unnecessarily
    complicated. Simplify it to just return directly on error.
    
    Signed-off-by: Ben Horgan <ben.horgan@xxxxxxx>
    Signed-off-by: Borislav Petkov (AMD) <bp@xxxxxxxxx>
    Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
    Reviewed-by: Babu Moger <babu.moger@xxxxxxx>
    Tested-by: Babu Moger <babu.moger@xxxxxxx>
    Link: https://lore.kernel.org/r/20260506082855.3694761-1-ben.horgan@xxxxxxx

diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c
index 5dfdaa6f9d8f..eca3bb67987d 100644
--- a/fs/resctrl/rdtgroup.c
+++ b/fs/resctrl/rdtgroup.c
@@ -2331,22 +2331,19 @@ static int resctrl_mkdir_event_configs(struct rdt_resource *r, struct kernfs_nod
 			continue;
 
 		kn_subdir2 = kernfs_create_dir(kn_subdir, mevt->name, kn_subdir->mode, mevt);
-		if (IS_ERR(kn_subdir2)) {
-			ret = PTR_ERR(kn_subdir2);
-			goto out;
-		}
+		if (IS_ERR(kn_subdir2))
+			return PTR_ERR(kn_subdir2);
 
 		ret = rdtgroup_kn_set_ugid(kn_subdir2);
 		if (ret)
-			goto out;
+			return ret;
 
 		ret = rdtgroup_add_files(kn_subdir2, RFTYPE_ASSIGN_CONFIG);
 		if (ret)
-			break;
+			return ret;
 	}
 
-out:
-	return ret;
+	return 0;
 }
 
 static int rdtgroup_mkdir_info_resdir(void *priv, char *name,

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette