Re: [PATCH v17 04/11] cxl: Rename find_cxl_port() to find_cxl_port_by_dport()
From: Jonathan Cameron
Date: Thu May 07 2026 - 14:11:57 EST
On Tue, 5 May 2026 15:06:42 -0700
Dave Jiang <dave.jiang@xxxxxxxxx> wrote:
> On 5/5/26 10:30 AM, Terry Bowman wrote:
> > From: Dan Williams <djbw@xxxxxxxxxx>
> >
> > find_cxl_port() and find_cxl_port_by_uport() are internal port lookup
> > functions that search the CXL bus by dport and uport respectively, but
> > their names do not make the lookup method clear.
> >
> > Rename find_cxl_port() to find_cxl_port_by_dport() to make the lookup
> > method explicit and consistent with find_cxl_port_by_uport(). Both
> > functions remain static to port.c; the upcoming patch that adds the
> > first cross-file caller will widen their scope.
> >
> > Co-developed-by: Terry Bowman <terry.bowman@xxxxxxx>
> > Signed-off-by: Terry Bowman <terry.bowman@xxxxxxx>
> > Signed-off-by: Dan Williams <djbw@xxxxxxxxxx>
>
> Reviewed-by: Dave Jiang <dave.jiang@xxxxxxxxx>
Reviewed-by: Jonathan Cameron <jic23@xxxxxxxxxx>
Could pick this one up independently / early given it's useful for
readability.