Re: [PATCH net-next 08/12] dt-bindings: net: toshiba,tc965x-dwmac: add TC956x Ethernet bridge

[Alex Elder]

On 5/1/26 12:38 PM, Andrew Lunn wrote:
> Why not add an subnodes for the ethernet interfaces?

We will define "ethernet" devicetree subnodes of the PCIe functions
in the next version of the series.  Something like what's below.

					-Alex

pci@0,1 {
        compatible = "pci1179,0220";
        reg = <0x50100 0x0 0x0 0x0 0x0>;
        #address-cells = <3>;
        #size-cells = <2>;
        device_type = "pci";
        ranges;

        ethernet {
                phy-mode = "sgmii";
                phy-handle = <&tc956x_emac1_phy>;

                mdio {
                        compatible = "snps,dwmac-mdio";
                        #address-cells = <1>;
                        #size-cells = <0>;

                        tc956x_emac1_phy: ethernet-phy@1c {
                                compatible = "ethernet-phy-id004d.d101";
				...
			};
		};
	};
};