[PATCH] talitos: use devm_platform_ioremap_resource()

From: Rosen Penev

Date: Thu May 07 2026 - 19:44:46 EST


platform_get_resource and devm_ioremap effectively open codes this.

The return type of devm_platform_ioremap_resource() is also nice as it
has multiple errors that it can return.

Because it internally calls devm_request_mem_region(), reg values and
sizes cannot overlap. This was manually verified to be the case for all
talitos users.

Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
---
drivers/crypto/talitos.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
index bd4cc06ee13c..bdf7549fdf0a 100644
--- a/drivers/crypto/talitos.c
+++ b/drivers/crypto/talitos.c
@@ -3412,7 +3412,6 @@ static int talitos_probe(struct platform_device *ofdev)
unsigned int num_channels;
int i, err;
int stride;
- struct resource *res;

if (of_property_read_u32(np, "fsl,num-channels", &num_channels))
return -EINVAL;
@@ -3431,13 +3430,10 @@ static int talitos_probe(struct platform_device *ofdev)

spin_lock_init(&priv->reg_lock);

- res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);
- if (!res)
- return -ENXIO;
- priv->reg = devm_ioremap(dev, res->start, resource_size(res));
- if (!priv->reg) {
+ priv->reg = devm_platform_ioremap_resource(ofdev, 0);
+ if (IS_ERR(priv->reg)) {
dev_err(dev, "failed to of_iomap\n");
- err = -ENOMEM;
+ err = PTR_ERR(priv->reg);
goto err_out;
}

--
2.54.0