Re: [net-next v39] mctp pcc: Implement MCTP over PCC Transport

[Jeremy Kerr]

Hi Adam,

> > This reads as if you're not updating stats at all, but you do so in
> > mctp_pcc_tx_prepare(). I don't think this comment is necessary - if
> > you really want to mention this, add a comment on the
> > dev_dstats_tx_add() to indicate why you're calling it early.
> 
> This comment is in prep for a fairly large change in the PCC layer to
> address it.
> 
> This statistic should be reported in tx_done, but cannot be done safely 
> yet.  The fix is to get tx_done out of a hard-irq handler. I will submit 
> that as a follow on changes to mailbox/pcc.c and mctp-pc.c

That's all good,  especially if there's a fix coming, but my suggestion
still stands - it would make more sense to comment the stats update in
_prepare(), rather than the absence of a stats update in _done().

Cheers,


Jeremy