Re: [PATCH v4 2/2] Input: isa1200 - new driver for Imagis ISA1200

[Dmitry Torokhov]

On Fri, May 08, 2026 at 02:13:43PM +0300, Svyatoslav Ryhel wrote:
> чт, 7 трав. 2026 р. о 22:26 Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> пише:
> >
> > Hi Svyatoslav,
> >
> > On Thu, May 07, 2026 at 04:39:48PM +0300, Svyatoslav Ryhel wrote:

...

> > > +}
> > > +
> > > +static int isa1200_suspend(struct device *dev)
> > > +{
> > > +     struct isa1200 *isa = dev_get_drvdata(dev);
> > > +
> > > +     cancel_work_sync(&isa->play_work);
> >
> > Move it under input_device_enabled().
> >
> > > +
> > > +     guard(mutex)(&isa->input->mutex);
> > > +
> 
> Should I remove mutex locking from both PM functions?

No, you should remove it from isa1200_play_work().

Thanks.

-- 
Dmitry