Re: [PATCH 2/2] staging: rtl8723bs: Fix coding style in include headers

From: Nikolay Kulikov

Date: Sun May 10 2026 - 13:07:41 EST


On Sun, May 10, 2026 at 08:01:37PM +0300, Nikolay Kulikov wrote:
> On Sun, May 10, 2026 at 11:17:21AM -0400, Pramod Maurya wrote:
> > Remove multiple blank lines and extern keywords from function
> > prototypes in header files as flagged by checkpatch.pl.
>
> Please one patch for one logical change.
>
>
> >
> > Files changed:
> > - rtw_wifi_regd.h: remove multiple blank lines
> > - sdio_ops_linux.h: remove multiple blank lines
> > - cmd_osdep.h: remove multiple blank lines and extern prototypes
> > - rtw_ioctl_set.h: remove multiple blank lines
> > - rtl8192c_recv.h: remove multiple blank lines
> > - rtl8723b_dm.h: remove multiple blank lines
>
> git diff does this for you perfectly well, why repeat it?

And you haven't added cover-letter (PATCH 0/2), you can do this with:
$ git format-patch --cover-letter ...

>
>
> Thanks,
> Nikolay