Re: [PATCH] staging: fbtft: check return value of device_create_file()

From: Dan Carpenter

Date: Mon May 11 2026 - 07:47:27 EST


On Mon, May 11, 2026 at 10:01:40AM +0000, Harshit Shaw wrote:
> device_create_file() can fail but its return value was being
> ignored in fbtft_sysfs_init(). Check the return value and
> emit a warning if sysfs file creation fails.
>
> Signed-off-by: Harshit Shaw <shawharshit116@xxxxxxxxx>
> ---

What's the point of this though? How is your warning message more
informative than the warning messages printed out by
device_create_file()?

regards,
dan carpenter