Re: [PATCH net-next v2 4/9] net: phy: ncn26000: Support for internal phy for S2500

From: Andrew Lunn

Date: Mon May 11 2026 - 16:30:53 EST


On Mon, May 11, 2026 at 07:35:15PM +0000, Selvamani Rajagopal wrote:
>
>
> >
> >
> > This Message Is From an External Sender
> > This message came from outside your organization.
> >
> > > @@ -163,7 +166,7 @@ static int ncn26000_config_intr(struct phy_device *phydev)
> > > }
> > >
> > > /* Directly accessing via Clause 45 read avoids the extra
> > > - * SPI accesses required by indirect access.
> > > + * SPI transactions required by indirect access.
> > > */
> >
> > Please don't change things you added in the previous patch.
>
> I thought v1 is abandoned once v2 is submitted. Didn't realized we diff v1 -> v2 too. Will be careful in avoiding it in future.

Wasn't this line added in a previous patch in this series? Patch 3/9 ?

Andrew