Re: [PATCH v4 1/4] arm64: dts: qcom: monaco-evk: Extract common EVK hardware into shared dtsi
From: Umang Chheda
Date: Tue May 12 2026 - 04:14:44 EST
On 5/6/2026 2:48 PM, Konrad Dybcio wrote:
> On 5/5/26 3:53 PM, Umang Chheda wrote:
>> Hello Krzysztof,
>>
>> On 5/5/2026 1:49 AM, Krzysztof Kozlowski wrote:
>>> On 04/05/2026 14:57, Konrad Dybcio wrote:
>>>> On 4/27/26 7:05 PM, Umang Chheda wrote:
>>>>> The monaco-ac EVK is a new board variant which shares the majority of
>>>>> its hardware description with the existing monaco-evk board.
>>>>>
>>>>> In preparation for adding this variant, extract the common hardware
>>>>> nodes from monaco-evk.dts into a new shared monaco-evk-common.dtsi
>>>>> include file, and update monaco-evk.dts to include it and keep only
>>>>> board-specific overrides.
>>>>>
>>>>> No functional change intended.
>>>>>
>>>>> Signed-off-by: Umang Chheda <umang.chheda@xxxxxxxxxxxxxxxx>
>>>>> ---
>>>>
>>>> The patch is a bit difficult to view as-is, but the gist of it is that
>>>> the resulting monaco-evk.dts is:
>>>
>>> Diff should be fixed and since this is not even b4, than producing
>>> proper patch detecting rename is trivial. :/
>>
>> I acknowledge it's hard to review the patch this way.
>>
>> I’ll rework the patch to use a proper rename (git mv) and keep the
>> follow-up changes minimal, so the diff cleanly shows the extraction into
>> monaco-evk-common.dtsi.
>
> Try adding this hunk to your gitconfig:
>
> [diff]
> renameLimit = 999999
> algorithm = histogram # or patience
> renames = copies
Thanks Konrad for the inputs, will add this and re-send the patch.
>
>
> Konrad