Re: [PATCH v7 4/8] iio: magnetometer: ak8975: consistently use 'data' parameter

[Joshua Crofts]

On Tue, 12 May 2026 at 17:03, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>
> On Mon, 11 May 2026 13:26:13 +0200
> Joshua Crofts via B4 Relay <devnull+joshua.crofts1.gmail.com@xxxxxxxxxx> wrote:
>
> > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> >
> > Some of the functions use 'client', some use 'data', and some use both.
> > Refactor the driver to consistently use 'data' in all cases.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>
> > Signed-off-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
> Note that whilst I've applied this sashiko pointed out some more
> while I was here issues.
>
> The one about not ensuring the power is on for buffered captures
> is a pretty major bug :(
>
> https://sashiko.dev/#/patchset/20260511-magnetometer-fixes-post-pickup-v7-0-9d910faa28b6%40gmail.com
>
> Which is a pain because we have lots of cleanup on this driver already
> and I don't want to rip it out.  The fix is pretty simple though
> (add a preenable, postdissable pair of opts and pm_runtime_get_sync()
> / put_autosuspend() as appropriate.
>
> So if you don't mind please put together that patch and I'll apply it
> via the testing/togreg tree and we'll do a manual backport later.

Oh well, at least Sashiko caught it. Thanks for the heads up.

--
Kind regards

CJD