Re: [PATCH] staging: Documentation: dds: replace frequencyY with frequency

[Abinash Singh]

On Tue, May 12, 2026 at 4:45 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
>
> On Mon, May 11, 2026 at 10:42:55PM +0530, Abinash Singh wrote:
>
> > The documented frequencyY attribute naming is implementation
>
> I'm lost here. What frequencyY? I don't see that in the patch.
> I think this needs to be more specific. Can you rephrase?
>
By "frequencyY", I meant the implementation-specific attribute naming
used in the documentation:
"/sys/bus/iio/devices/.../out_altvoltageX_frequencyY"
 where Y represents the tuning word register
index (for example frequency0/frequency1 corresponding to FREQ0/FREQ1
in devices like AD9834).

> > specific and differs from common IIO sysfs attribute
> > conventions.
> >
> > Replace the non-standard frequencyY attribute documentation with
> > out_altvoltageX_frequency and document tuning word selection
> > through out_altvoltageX_frequencysymbol
>
> Missing space?
Thanks
>
> > This makes the documented ABI naming consistent with standard
> > IIO sysfs attribute conventions and clarifies how tuning word
> > registers are selected and programmed.
> >
> >
>
> (A single blank line is enough.)

acknowledged.
>
> > Signed-off-by: Abinash Singh <abinashlalotra@xxxxxxxxx>
> > ---
> >
> > The out_altvoltageX_frequencysymbol and
> > out_altvoltageX_frequency_scale attributes can be added
> > through extended channel attributes (.ext_info in channel_spec struct of IIO)
> >
> > Feedback on this approach would be appreciated, and if
> > there is some other way in your mind. I would like to
> > work on that.
> >
> > I am also interested in working on the sysfs-bus-iio-dds
> > documentation and the ad9834 driver. I recently bought an
> > AD9833 IC for experimentation and testing.
>
> I didn't get is the current documentation wrong or is it that currently
> used ABI is wrong?
>
The current ABI and documentation are consistent with the current driver
implementation

But it uses implementation-specific naming using "IIO_DEVICE_ATTR" ,
such as "frequency0" and "frequency1" for DDS tuning word selection.

As this was in staging. It may be because it is not aligned
with standard IIO ABI naming convention such as "out_altvoltageX_frequency"
This is what I observed. It may be incorrect.

If there are any other
reasons why this is in staging ?, I would love to work on that.

And from Jonathan's reply I realised that I was wrong about
/sys/bus/iio/devices/.../out_altvoltageX_frequencysymbol


> --
> With Best Regards,
> Andy Shevchenko
>
>
Thank You very much for your time
Abinash Singh