Re: [PATCH v1 1/1] ALSA: hda/cs35l56: Drop malformed default N from Kconfig

[Richard Fitzgerald]

On 13/05/2026 5:27 pm, Andy Shevchenko wrote:
> First of all, it has to be 'default n' (small letter n), otherwise
> it looks for CONFIG_N which is absent and in case of appearance
> will enable something unrelated. Second and most important is that
> 'n' *is* the default 'default' already. Hence just drop malformed
> line.

The redundant default was added intentionally to be explicit that the
default really must be "no". But if that sort of thing is forbidden you
can drop the line.

I apologize for the typo, but that is why you shouldn't use case
difference as language syntax.

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>   sound/hda/codecs/side-codecs/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/sound/hda/codecs/side-codecs/Kconfig b/sound/hda/codecs/side-codecs/Kconfig
> index fc5651e555e3..e51964c0a091 100644
> --- a/sound/hda/codecs/side-codecs/Kconfig
> +++ b/sound/hda/codecs/side-codecs/Kconfig
> @@ -94,7 +94,6 @@ menu "CS35L56 driver options"
>   
>   config SND_HDA_SCODEC_CS35L56_CAL_DEBUGFS
>   	bool "CS35L56 create debugfs for factory calibration"
> -	default N
>   	depends on DEBUG_FS
>   	select SND_SOC_CS35L56_CAL_DEBUGFS_COMMON
>   	help