Re: [PATCH v1 1/1] ALSA: hda/cs35l56: Drop malformed default N from Kconfig
From: Andy Shevchenko
Date: Wed May 13 2026 - 13:24:22 EST
On Wed, May 13, 2026 at 08:22:23PM +0300, Andy Shevchenko wrote:
> On Wed, May 13, 2026 at 05:46:03PM +0100, Richard Fitzgerald wrote:
> > On 13/05/2026 5:27 pm, Andy Shevchenko wrote:
> > > First of all, it has to be 'default n' (small letter n), otherwise
> > > it looks for CONFIG_N which is absent and in case of appearance
> > > will enable something unrelated. Second and most important is that
> > > 'n' *is* the default 'default' already. Hence just drop malformed
> > > line.
> >
> > The redundant default was added intentionally to be explicit that the
> > default really must be "no". But if that sort of thing is forbidden you
> > can drop the line.
>
> Torvalds gave his opinion on the Subject a few years ago, here is what he would
> do.
>
> 0192f17529fa ("clean up x86 platform driver default values")
Based on that, can you give your tag, please? (Also for ASoC case.)
--
With Best Regards,
Andy Shevchenko