Re: [RFC PATCH] pps: make number of PPS devices configurable

From: Jakub Kicinski

Date: Thu May 14 2026 - 10:14:18 EST


On Thu, 14 May 2026 15:03:03 +0100 Vadim Fedorenko wrote:
> On 14/05/2026 14:55, Jakub Kicinski wrote:
> > On Thu, 14 May 2026 11:26:14 +0000 Vadim Fedorenko wrote:
> >> Modern systems may have more than 16 PPS sources and current hard-coded
> >> limit breaks registration of some devices. Make the limit configurable
> >> via Kconfig, keep default value of 16 devices. UAPI has to be changed to
> >> support maximum possible number.
> >
> > Hm, since this is effectively just sizing an IDR maybe we should just
> > bump it to 64? It appears to cost nothing if not used.
>
> Just bump to 64, but keep it constant? In this case maybe 256 just to
> align with the max minor value for chardev (in compat mode)?

That's fine too (the value is the count right? It's not the max id?
Cause 256 would spill out of u8)