Re: [PATCH 3/5] dt-bindings: usb: qcom,dwc3: Add ipq5210 to USB DWC3 bindings
From: Krzysztof Kozlowski
Date: Fri May 15 2026 - 07:09:18 EST
On 15/05/2026 12:47, Varadarajan Narayanan wrote:
> Update dt-bindings to add ipq5210 to USB DWC3 controller list.
>
> Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@xxxxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 +
> 1 file changed, 1 insertion(+)
Same feedback as usually. What USB patch is doing here?
Also, other typical comment:
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Considering that did not pass through internal review toolset and it has
trivial issues, which this toolset and internal review is suppose to
catch, I drop all patches from you from the DT Patchwork.
Best regards,
Krzysztof