Re: Re: [RFC PATCH 1/1] mv88e6xxx: Cache scratch config of 6352 in setup

[Andrew Lunn]

> I have one more question; now that mv88e6352_g2_scratch_port_has_serdes()
> never returns a value smaller than 0, should all the callers be aware of
> this fact?

You could make it a boolean function.

Shall I change the checks for return value on this function not
> to check for <0 ? All the callers except 1 will be refactored to use
> serdes_get_lane function later, so it might be unnecessary.

but if the code is going to be refactored, it is not really necessary.

    Andrew