Re: [PATCH net 2/2] dt-bindings: net: updated interrupt type to be active low, level triggered
From: Andrew Lunn
Date: Fri May 15 2026 - 15:06:46 EST
On Fri, May 15, 2026 at 06:15:50PM +0200, Krzysztof Kozlowski wrote:
> On 15/05/2026 18:13, Selvamani Rajagopal wrote:
> > According to OPEN Alliance 10BASE-T1x MACPHY Serial Interface (TC6)
> > specification, interrupt type is active low, level triggered interrupt.
> >
> > Fixes: ac49b950bea9 ("dt-bindings: net: add Microchip's LAN865X 10BASE-T1S MACPHY")
>
> Drop, there is no bug here. That is only an example. Otherwise explain
> how does this bug affect anything.
There is a tendency for DT developers to just copy/paste the example,
and not really engage brain. So if the example is wrong, the .dts file
will be wrong.
The thing about edge interrupts when level should be used is that they
mostly work. So quick smoke testing is not going to see any problems,
it is only when some condition comes along which causes two interrupts
in quick succession will the interface grind to a halt due to a missed
interrupt.
So i think it is a useful fix to have in stable.
Andrew