Re: [PATCH v4 2/2] iio: adc: add support for PAC194X

From: David Lechner

Date: Sat May 16 2026 - 12:40:25 EST


On 5/15/26 4:29 AM, marius.cristea@xxxxxxxxxxxxx wrote:
> From: Marius Cristea <marius.cristea@xxxxxxxxxxxxx>
>
> This is the iio driver for Microchip PAC194X and PAC195X series of
> Power Monitors with Accumulator. The PAC194X family supports 9V
> Full-Scale Range and the PAC195X supports 32V Full-Scale Range.
>
> There are two versions of the PAC194X/5X: the PAC194X/5X-1 devices
> are for high-side current sensing and the PAC194X/5X-2 devices are
> for low-side current sensing or floating VBUS applications. The
> PAC194X/5X-1 is named shortly PAC194X/5X.
>
> Signed-off-by: Marius Cristea <marius.cristea@xxxxxxxxxxxxx>
> ---
> MAINTAINERS | 1 +
> drivers/iio/adc/Kconfig | 12 +
> drivers/iio/adc/Makefile | 1 +
> drivers/iio/adc/pac1944.c | 2172 +++++++++++++++++++++++++++++++++++++
> 4 files changed, 2186 insertions(+)
> create mode 100644 drivers/iio/adc/
Can we please split this up into multiple patches by feature added?

We are already drowning in reviews here in the IIO subsystem. It takes
many times longer to review things that are not split up into bite-sized
pieces (aim for 500 lines in a patch).