Re: [PATCH] x86/mm: keep the PROCESSOR_SELECT menu together
From: Randy Dunlap
Date: Sun May 17 2026 - 13:51:56 EST
On 5/16/26 9:37 PM, Randy Dunlap wrote:
> Having a stray kconfig symbol in the middle of the PROCESSOR_SELECT menu
> (this symbol plus its dependent symbols) causes the menu dependencies
> not to be displayed correctly in gconfig and xconfig.
> (It seems not to matter in menuconfig and nconfig.)
That parenthetical remark is incorrect. It does affect the menu in
menuconfig and nconfig.
> Move the BROADCAST_TLB_FLUSH symbol away from the PROCESSOR_SELECT menu
> so that the list of processors is displayed correctly.
>
> Fixes: 767ae437a32d ("x86/mm: Add INVLPGB feature and Kconfig entry")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> ---
> Cc: Rik van Riel <riel@xxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>
> Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> Cc: x86@xxxxxxxxxx
>
> arch/x86/Kconfig.cpu | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> --- linux-next-20260508.orig/arch/x86/Kconfig.cpu
> +++ linux-next-20260508/arch/x86/Kconfig.cpu
> @@ -302,10 +302,6 @@ menuconfig PROCESSOR_SELECT
> This lets you choose what x86 vendor support code your kernel
> will include.
>
> -config BROADCAST_TLB_FLUSH
> - def_bool y
> - depends on CPU_SUP_AMD && 64BIT
> -
> config CPU_SUP_INTEL
> default y
> bool "Support Intel processors" if PROCESSOR_SELECT
> @@ -412,3 +408,7 @@ config CPU_SUP_VORTEX_32
> makes the kernel a tiny bit smaller.
>
> If unsure, say N.
> +
> +config BROADCAST_TLB_FLUSH
> + def_bool y
> + depends on CPU_SUP_AMD && 64BIT
--
~Randy