Re: [PATCH v3 3/4] arm64: dts: qcom: add basic devicetree for Ayaneo Pocket DS gaming console

[Neil Armstrong]

On 5/17/26 15:14, Alexandre Hamamdjian via B4 Relay wrote:
> From: Teguh Sobirin <teguh@xxxxxxxx>
>
> Add initial Device Tree for the Ayaneo Pocket DS gaming console based
> on the Qualcomm QCS8550 platform.
>
> The design is similar to a phone without the modem, the game control
> is handled via a standalone controller connected to a Renesas uPD720201
> PCIe USB 3.0 host controller. DisplayPort is muxed over the USB-C
> connector with all four lanes wired.
>
> Display panel support will be added in a second time.
>
> Co-developed-by: Alexandre Hamamdjian <azkali.limited@xxxxxxxxx>
> Signed-off-by: Alexandre Hamamdjian <azkali.limited@xxxxxxxxx>
> Signed-off-by: Teguh Sobirin <teguh@xxxxxxxx>
> ---
>   arch/arm64/boot/dts/qcom/Makefile                  |    1 +
>   .../boot/dts/qcom/qcs8550-ayaneo-pocketds.dts      | 1883 ++++++++++++++++++++
>   2 files changed, 1884 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index cc42829f92eb..45859e977bc9 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -185,6 +185,7 @@ qcs8300-ride-el2-dtbs := qcs8300-ride.dtb monaco-el2.dtbo
>   
>   dtb-$(CONFIG_ARCH_QCOM)	+= qcs8300-ride-el2.dtb
>   dtb-$(CONFIG_ARCH_QCOM)	+= qcs8550-aim300-aiot.dtb
> +dtb-$(CONFIG_ARCH_QCOM)	+= qcs8550-ayaneo-pocketds.dtb
>   dtb-$(CONFIG_ARCH_QCOM)	+= qcs9100-ride.dtb
>   dtb-$(CONFIG_ARCH_QCOM)	+= qcs9100-ride-r3.dtb
>   
> diff --git a/arch/arm64/boot/dts/qcom/qcs8550-ayaneo-pocketds.dts b/arch/arm64/boot/dts/qcom/qcs8550-ayaneo-pocketds.dts
> new file mode 100644
> index 000000000000..416399a4179b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/qcs8550-ayaneo-pocketds.dts
> @@ -0,0 +1,1883 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2025, Teguh Sobirin.
> + * Copyright (c) 2025, ROCKNIX (https://github.com/ROCKNIX)
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> +#include "qcs8550.dtsi"
> +#include "pm8550.dtsi"
> +#include "pm8550b.dtsi"
> +#define PMK8550VE_SID 5
> +#include "pm8550ve.dtsi"
> +#include "pm8550vs.dtsi"
> +#include "pmk8550.dtsi"
> +
> +/delete-node/ &aop_image_mem;
> +/delete-node/ &aop_config_mem;
> +/delete-node/ &camera_mem;
> +/delete-node/ &ipa_fw_mem;
> +/delete-node/ &ipa_gsi_mem;
> +/delete-node/ &mpss_dsm_mem;
> +/delete-node/ &mpss_mem;
> +/delete-node/ &q6_mpss_dtb_mem;
> +/delete-node/ &cdsp_mem;
> +/delete-node/ &q6_cdsp_dtb_mem;
> +
> +/delete-node/ &remoteproc_mpss;
> +/delete-node/ &remoteproc_cdsp;
> +
> +/ {
> +	model = "AYANEO Pocket DS";
> +	compatible = "ayaneo,pocketds", "qcom,qcs8550", "qcom,sm8550";
> +	rocknix-u-boot-dt-id = "u-boot-pocket-ds";

Seems you completely ignored Sahisko & my comments on top:
https://lore.kernel.org/all/1d04c00d-ee66-4467-b60e-f36326b90f11@xxxxxxxxxx/

> +
> +	aliases {
> +		serial0 = &uart7;
> +		serial1 = &uart14;
> +		hsuart0 = &uart11;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +
> +	pmic-glink {
> +		compatible = "qcom,sm8550-pmic-glink", "qcom,pmic-glink";
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		orientation-gpios = <&tlmm 11 GPIO_ACTIVE_HIGH>;
> +
> +		connector@0 {
> +			compatible = "usb-c-connector";
> +
> +			reg = <0>;
> +
> +			power-role = "dual";
> +			data-role = "dual";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +
> +					pmic_glink_hs_in: endpoint {
> +						remote-endpoint = <&usb_1_dwc3_hs>;
> +					};
> +				};
> +
> +				port@1 {
> +					reg = <1>;
> +
> +					pmic_glink_ss_in: endpoint {
> +						remote-endpoint = <&redriver_ss_out>;
> +					};
> +				};

Ditto

> +			};
> +		};
> +	};
> +
> +	pwm_fan: pwm-fan {
> +		compatible = "pwm-fan";
> +
> +		pinctrl-0 = <&fan_pwm_active>, <&fan_int>;
> +		pinctrl-names = "default", "sleep";
> +
> +		fan-supply = <&vdd_fan_5v0>;
> +		pwms = <&pm8550_pwm 3 40000>;
> +
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <64 IRQ_TYPE_EDGE_FALLING>;
> +
> +		#cooling-cells = <2>;
> +		cooling-levels = <0 30 45 60 70 90 120 150>;
> +	};
> +

<snip>

> +
> +	sound {
> +		compatible = "qcom,sm8550-sndcard", "qcom,sm8450-sndcard";
> +		model = "SM8550-APS";
> +
> +		audio-routing = "SpkrLeft IN", "WSA_SPK1 OUT",
> +				"SpkrRight IN", "WSA_SPK2 OUT",
> +				"VA DMIC0", "vdd-micb",
> +				"VA DMIC1", "vdd-micb";

Ditto

> +
> +		wsa-dai-link {
> +			link-name = "WSA Playback";
> +
> +			cpu {
> +				sound-dai = <&q6apmbedai WSA_CODEC_DMA_RX_0>;
> +			};
> +
> +			codec {
> +				sound-dai = <&spk_amp_l>,
> +					    <&spk_amp_r>,
> +					    <&swr0 0>,
> +					    <&lpass_wsamacro 0>;
> +			};
> +
> +			platform {
> +				sound-dai = <&q6apm>;
> +			};
> +		};
> +
> +		va-dai-link {
> +			link-name = "VA Capture";
> +
> +			cpu {
> +				sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>;
> +			};
> +
> +			codec {
> +				sound-dai = <&lpass_vamacro 0>;
> +			};
> +
> +			platform {
> +				sound-dai = <&q6apm>;
> +			};
> +		};
> +	};
> +

<snip>

> +};
> +
> +&cpu7_top_thermal {
> +	polling-delay = <200>;
> +
> +	trips {
> +		cpu7_top_fan0: trip-point2 {
> +			temperature = <70000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};

Ditto

> +
> +		cpu7_top_fan1: trip-point3 {
> +			temperature = <75000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpu7_top_fan2: trip-point4 {
> +			temperature = <80000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +	};
> +};
> +
> +&cpuss0_thermal {
> +	polling-delay = <200>;
> +
> +	trips {
> +		cpuss0_fan0: trip-point2 {
> +			temperature = <40000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss0_fan1: trip-point3 {
> +			temperature = <50000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss0_fan2: trip-point4 {
> +			temperature = <60000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss0_fan3: trip-point5 {
> +			temperature = <65000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss0_fan4: trip-point6 {
> +			temperature = <70000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss0_fan5: trip-point7 {
> +			temperature = <75000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss0_fan6: trip-point8 {
> +			temperature = <80000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +	};
> +};
> +
> +&cpuss1_thermal {
> +	polling-delay = <200>;
> +
> +	trips {
> +		cpuss1_fan0: trip-point2 {
> +			temperature = <40000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss1_fan1: trip-point3 {
> +			temperature = <50000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss1_fan2: trip-point4 {
> +			temperature = <60000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss1_fan3: trip-point5 {
> +			temperature = <65000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss1_fan4: trip-point6 {
> +			temperature = <70000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss1_fan5: trip-point7 {
> +			temperature = <75000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss1_fan6: trip-point8 {
> +			temperature = <80000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +	};
> +};
> +
> +&cpuss2_thermal {
> +	polling-delay = <200>;
> +
> +	trips {
> +		cpuss2_fan0: trip-point2 {
> +			temperature = <40000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss2_fan1: trip-point3 {
> +			temperature = <50000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss2_fan2: trip-point4 {
> +			temperature = <60000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss2_fan3: trip-point5 {
> +			temperature = <65000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss2_fan4: trip-point6 {
> +			temperature = <70000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss2_fan5: trip-point7 {
> +			temperature = <75000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss2_fan6: trip-point8 {
> +			temperature = <80000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +	};
> +};
> +
> +&cpuss3_thermal {
> +	polling-delay = <200>;
> +
> +	trips {
> +		cpuss3_fan0: trip-point2 {
> +			temperature = <40000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss3_fan1: trip-point3 {
> +			temperature = <50000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss3_fan2: trip-point4 {
> +			temperature = <60000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss3_fan3: trip-point5 {
> +			temperature = <65000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss3_fan4: trip-point6 {
> +			temperature = <70000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss3_fan5: trip-point7 {
> +			temperature = <75000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +
> +		cpuss3_fan6: trip-point8 {
> +			temperature = <80000>;
> +			hysteresis = <3000>;
> +			type = "passive";
> +		};
> +	};
> +};
> +
> +&gpi_dma1 {
> +	status = "okay";
> +};
> +
> +&gpi_dma2 {
> +	status = "okay";
> +};
> +
> +&gpu {
> +	status = "okay";
> +};
> +
> +&gpu_opp_table {
> +	opp-719000000 {
> +		opp-hz = /bits/ 64 <719000000>;
> +		opp-level = <RPMH_REGULATOR_LEVEL_SVS_L2>;
> +		opp-peak-kBps = <10687500>;
> +		qcom,opp-acd-level = <0x882e5ffd>;
> +	};
> +
> +	opp-746000000 {
> +		opp-hz = /bits/ 64 <746000000>;
> +		opp-level = <RPMH_REGULATOR_LEVEL_NOM>;
> +		opp-peak-kBps = <10687500>;
> +		qcom,opp-acd-level = <0x882e5ffd>;
> +	};
> +
> +	opp-794000000 {
> +		opp-hz = /bits/ 64 <794000000>;
> +		opp-level = <RPMH_REGULATOR_LEVEL_NOM_L1>;
> +		opp-peak-kBps = <14398438>;
> +		qcom,opp-acd-level = <0xa82d5ffd>;
> +	};
> +
> +	opp-827000000 {
> +		opp-hz = /bits/ 64 <827000000>;
> +		opp-level = <RPMH_REGULATOR_LEVEL_TURBO>;
> +		opp-peak-kBps = <16500000>;
> +		qcom,opp-acd-level = <0xa82d5ffd>;
> +	};
> +
> +	opp-860000000 {
> +		opp-hz = /bits/ 64 <860000000>;
> +		opp-level = <RPMH_REGULATOR_LEVEL_TURBO_L1>;
> +		opp-peak-kBps = <16500000>;
> +		qcom,opp-acd-level = <0x882d5ffd>;
> +	};
> +
> +	opp-1000000000 {
> +		opp-hz = /bits/ 64 <1000000000>;
> +		opp-level = <RPMH_REGULATOR_LEVEL_TURBO_L2>;
> +		opp-peak-kBps = <16500000>;
> +		qcom,opp-acd-level = <0x882d5ffd>;
> +	};
> +};

Please drop this until we properly implement support for detecting those dynamically

> +};
> +
> +&mdss {
> +	status = "okay";
> +};
> +
> +&mdss_dp0 {
> +	status = "okay";
> +};
> +
> +&mdss_dp0_out {
> +	remote-endpoint = <&panel0_in>;
> +
> +	data-lanes = <0 1 2 3>;
> +};
> +
> +&mdss_dsi0 {
> +	vdda-supply = <&vreg_l3e_1p2>;
> +
> +	status = "okay";
> +
> +	display_panel: panel@0 {
> +		reg = <0>;
> +
> +		pinctrl-0 = <&sde_dsi_active>, <&sde_te_active>;
> +		pinctrl-1 = <&sde_dsi_suspend>, <&sde_te_suspend>;
> +		pinctrl-names = "default", "sleep";
> +	};

Ditto, again, drop all Display related nodes until the display bindings are
reviewed, don't keep a node without compatible.

> +};
> +
> +&mdss_dsi0_phy {
> +	vdds-supply = <&vreg_l1e_0p88>;
> +
> +	status = "okay";
> +};
> +

<snip>

>

And again, don't submit v4 _without_ testing the DT against the bindings so it returns 0 errors:

arch/arm64/boot/dts/qcom/sm8550.dtsi:3878.30-3881.9: ERROR (phandle_references): /soc@0/display-subsystem@ae00000/displayport-controller@ae90000/ports/port@1/endpoint: Reference to non-existent node or label "panel0_in"

  also defined at arch/arm64/boot/dts/qcom/qcs8550-ayaneo-pocketds.dts:1381.15-1385.3
arch/arm64/boot/dts/qcom/sm8550.dtsi:4056.31-4057.9: ERROR (phandle_references): /soc@0/display-subsystem@ae00000/dsi@ae96000/ports/port@1/endpoint: Reference to non-existent node or label "panel1_in"

Neil