Re: [PATCH v3 2/4] sched/fair: Skip misfit load accounting when the destination CPU cannot help

[Ricardo Neri]

On Fri, May 15, 2026 at 08:49:18PM +0800, Chen, Yu C wrote:
> On 5/15/2026 2:34 AM, Ricardo Neri wrote:
> 
> > +			if (rq->misfit_task_load) {
> > +				/*
> > +				 * Always mark the domain overloaded so big CPUs
> > +				 * can pick up misfit tasks via newly idle
> > +				 * balance.
> > +				 */
> >   				*sg_overloaded = 1;
> 
> if (balancing_at_rd)
> 	*sg_overloaded = 1
> to avoid confusing non-root domain(although in current code only
> root domain checks this)

You are correct. I don't think this needs to be done unless we are at the
root domain. This is because update_sd_lb_stats() will only consider this
variable at the root domain. This is an existing, if harmless, bug.

I will modify my series to fix this.
> 
> But the original logic does not have this check, it should be OK.
> 
> Reviewed-by: Chen Yu <yu.c.chen@xxxxxxxxx>

Thanks you!