Re: [PATCH v5 2/7] x86/msr: add wrmsrq_on_cpus helper

[Dave Hansen]

On 5/18/26 15:09, Kalra, Ashish wrote:
> On 5/18/2026 5:04 PM, Dave Hansen wrote:
>> On 5/18/26 14:42, Ashish Kalra wrote:
>>> Co-developed-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
>>> Signed-off-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
>>> Reviewed-by: Ackerley Tng <ackerleytng@xxxxxxxxxx>
>>> Signed-off-by: Ashish Kalra <ashish.kalra@xxxxxxx>
>> Hi Ashish,
>>
>> Sorry if my memory fails me, but I don't remember signing off on this.
>> Could you point me to the place where I gave you my Signed-off-by?
> Sorry about this, added this accidentally. 
> 
> You had suggested the code change, i accidentally took it as a Signed-off.

Hi Ashish,

First, please do me a favor and go back and re-read:

	Documentation/process/submitting-patches.rst

I recommend that everyone do this every once in a while so they remember
what they are constantly signing off on. It's important.

My personal rule for SoB lines is that I don't add them unless I've
explicitly talked to the person. Even then, I vastly prefer that the
person provides it to me *explicitly* (so I just copy and paste
directly) and on a public mailing list. That way, the avenues for
accidents to occur are very narrow.