[PATCH] irqchip/dw-apb-ictl: fix compilation on x86
From: Rosen Penev
Date: Mon May 18 2026 - 23:06:01 EST
__irq_entry belongs nowhere in irqchip drivers as it is an
architecture specific annotation. There's no specific architecture
depends for DW_APB_ICTL and there probably shouldn't be.
Fixes:
drivers/irqchip/irq-dw-apb-ictl.c:33:13: error: variable has incomplete type 'void'
33 | static void __irq_entry dw_apb_ictl_handle_irq(struct pt_regs *regs)
| ^
./arch/x86/include/asm/irq.h:19:21: note: expanded from macro '__irq_entry'
19 | #define __irq_entry __invalid_section
| ^
drivers/irqchip/irq-dw-apb-ictl.c:33:24: error: expected ';' after top level declarator
33 | static void __irq_entry dw_apb_ictl_handle_irq(struct pt_regs *regs)
| ^
| ;
CC drivers/bus/fsl-mc/dpcon.o
drivers/irqchip/irq-dw-apb-ictl.c:205:18: error: use of undeclared identifier 'dw_apb_ictl_handle_irq'
205 | set_handle_irq(dw_apb_ictl_handle_irq);
| ^~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
---
drivers/irqchip/irq-dw-apb-ictl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-dw-apb-ictl.c b/drivers/irqchip/irq-dw-apb-ictl.c
index 4240a0dbf627..2cf82bdd720f 100644
--- a/drivers/irqchip/irq-dw-apb-ictl.c
+++ b/drivers/irqchip/irq-dw-apb-ictl.c
@@ -30,7 +30,7 @@
/* irq domain of the primary interrupt controller. */
static struct irq_domain *dw_apb_ictl_irq_domain;
-static void __irq_entry dw_apb_ictl_handle_irq(struct pt_regs *regs)
+static void dw_apb_ictl_handle_irq(struct pt_regs *regs)
{
struct irq_domain *d = dw_apb_ictl_irq_domain;
int n;
--
2.54.0