RE: [EXTERNAL] Re: [PATCH net-next v2 6/9] net: atlantic: implement AQC113 L2/L3/L4 RX filter management filter management management

[Sukhdeep Soni [C]]

On 12 May 2026, Paolo Abeni wrote:

> @@ -530,6 +580,35 @@ static int hw_atl2_hw_init_rx_path(struct aq_hw_s *self)
>  	return aq_hw_err_from_flags(self);
>  }
>  
> +static int hw_atl2_hw_mac_addr_set(struct aq_hw_s *self, const u8 *mac_addr)
> +{
> +	struct hw_atl2_priv *priv = self->priv;
> +	u32 location = priv->l2_filters_base_index;
> +	unsigned int h;
> +	unsigned int l;
> +	int err;
>
> Minor nit: please respect the reverse christmas tree above (and elsewhere)

Sure, will keep that in mind and will fix that in v3.

>
> Side note: this patch is quite big, IMHO too much to be effectively
> reviewed without relying entirely on automated tools, please try split
> it into smaller chunks.
>

Agreed, will split patch 6 in v3

> Also, when posting the next revision please on avoid send the patch in
> reply to the previous iteration: it will foul both the tools and the
> human behind them.
>

Understood, will post v3 as a fresh thread rather than in reply to v2.

> Finally please note that the patch subj contains repeated words, please
> drop them.

Fixed in v3.

> 
> /P