Re: [PATCH v2 1/2] regulator: Drop unused i2c driver data

[Laurent Pinchart]

On Tue, May 19, 2026 at 11:57:50AM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> The two drivers explicitly set .driver_data to zero but don't use this
> value. So drop the explicit assignment.
> 
> While touching these arrays, unify usage of whitespace and commas.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
>  drivers/regulator/max77675-regulator.c | 2 +-
>  drivers/regulator/pf530x-regulator.c   | 8 ++++----
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/regulator/max77675-regulator.c b/drivers/regulator/max77675-regulator.c
> index af3eb7174875..57350526afd7 100644
> --- a/drivers/regulator/max77675-regulator.c
> +++ b/drivers/regulator/max77675-regulator.c
> @@ -1029,7 +1029,7 @@ static int max77675_regulator_probe(struct i2c_client *client)
>  }
>  
>  static const struct i2c_device_id max77675_i2c_id[] = {
> -	{ "max77675", 0 },
> +	{ "max77675" },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, max77675_i2c_id);
> diff --git a/drivers/regulator/pf530x-regulator.c b/drivers/regulator/pf530x-regulator.c
> index f789c4b6a499..ef3d5bb784cd 100644
> --- a/drivers/regulator/pf530x-regulator.c
> +++ b/drivers/regulator/pf530x-regulator.c
> @@ -353,10 +353,10 @@ static const struct of_device_id pf530x_dt_ids[] = {
>  MODULE_DEVICE_TABLE(of, pf530x_dt_ids);
>  
>  static const struct i2c_device_id pf530x_i2c_id[] = {
> -	{ "pf5300", 0 },
> -	{ "pf5301", 0 },
> -	{ "pf5302", 0 },
> -	{},
> +	{ "pf5300" },
> +	{ "pf5301" },
> +	{ "pf5302" },
> +	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, pf530x_i2c_id);
>  

-- 
Regards,

Laurent Pinchart