Re: [PATCH v2] ipv6: route: Unregister netdevice notifier on BPF init failure

[최유호]

Dear Jakub,

Thanks for pointing out the outdated tree. I will definitely rebase
and resubmit v3 against netdev/net.git.

Regarding the goto: The reason I moved away from the goto approach in
v2 is that if CONFIG_BPF_SYSCALL and CONFIG_PROC_FS are disabled, the
goto statement is compiled out. This leaves the target label unused,
triggering an "unused-label" compiler warning.

Since guarding labels with #ifdefs can get messy, I opted for the
direct unregistration in the failure path for v2 to keep it clean.

Would you still prefer I use the goto and guard the label
appropriately in v3, or is direct unregistration acceptable given the
warning?

Best regards,
Yuho

On Mon, 18 May 2026 at 20:14, Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Fri, 15 May 2026 09:05:17 -0400 Yuho Choi wrote:
> > Chages since v1:
> > - Unregister ip6_route_dev_notifier directlry in the bpf_iter_register() failure path.
>
> The goto was fine.
> You're generating the patch against an old version of the source code.
> Please use
> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
>
> Or for networking fixes better still:
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/
> --
> pw-bot: cr