Re: [PATCH 1/2] platform/x86: hp-wmi: Add support for Omen 16-b1xxx (8A13)

[Ilpo Järvinen]

On Wed, 13 May 2026, foobisdweik wrote:

> Add board name 8A13 (OMEN by HP Laptop 16-b1xxx, 12th-gen Intel/RTX 30
> series) to the Omen thermal-profile, timed-thermal-profile, and Victus-S
> DMI lists.
> 
> The 8A13 firmware exposes the standard Omen "PerformanceControl" WMI
> feature, uses the legacy EC thermal-profile offset (0x95), and
> implements the Victus-S-style GM2D/GM2E WMI methods at EC offsets
> 0xB0..0xB3 (RPM1..RPM4 tach) and 0x34..0x35 (SRP1/SRP2 setpoints).
> This makes it identical in interface to its same-era sibling 8A44
> (Omen 16-n0xxx), so reuse omen_v1_legacy_thermal_params.
> 
> After this change /sys/firmware/acpi/platform_profile reports
> cool/balanced/performance and the hp hwmon device exposes per-fan
> tachs plus the manual-mode pwm control on Omen 16-b1xxx.
> 
> Signed-off-by: foobisdweik <dweikmferris@xxxxxxxxx>

Hi,

Thanks for the patch, but we're not allowed to take in patches with sign 
off lines using nicknames or pseudo names (please see 
Documentation/process/submitting-patches.rst).

> ---
>  drivers/platform/x86/hp/hp-wmi.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
> index 24c151289dd3..389506a6d2e3 100644
> --- a/drivers/platform/x86/hp/hp-wmi.c
> +++ b/drivers/platform/x86/hp/hp-wmi.c
> @@ -157,7 +157,7 @@ static const char * const omen_thermal_profile_boards[] = {
>  	"886B", "886C", "88C8", "88CB", "88D1", "88D2", "88F4", "88F5", "88F6",
>  	"88F7", "88FD", "88FE", "88FF",
>  	"8900", "8901", "8902", "8912", "8917", "8918", "8949", "894A", "89EB",
> -	"8A15", "8A42",
> +	"8A13", "8A15", "8A42",
>  	"8BAD",
>  	"8C58",
>  	"8E41",
> @@ -177,7 +177,7 @@ static const char * const omen_thermal_profile_force_v0_boards[] = {
>   * "balanced" when reaching zero.
>   */
>  static const char * const omen_timed_thermal_profile_boards[] = {
> -	"8A15", "8A42",
> +	"8A13", "8A15", "8A42",
>  	"8BAD",
>  };
>  
> @@ -189,6 +189,10 @@ static const char * const victus_thermal_profile_boards[] = {
>  
>  /* DMI Board names of Victus 16-r and Victus 16-s laptops */
>  static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst = {
> +	{
> +		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8A13") },
> +		.driver_data = (void *)&omen_v1_legacy_thermal_params,
> +	},

I'll soon be pushing out review-ilpo-fixes branch, which will add 8902 
here. In order to avoid conflict with it, please base this change on top 
of it.

>  	{
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8A44") },
>  		.driver_data = (void *)&omen_v1_legacy_thermal_params,
> 

-- 
 i.